dev/core#2758 - Fix contribution activity campaign propagation ...more

[eileenmcnaughton]

Overview

Fixes master-only regression #21167

Before

Can't create a membership with no campaign on back office membership form

After

Can

Technical Details

In this scenarion $contribution->campaign_id is 'null' when it reaches this line & hence it fails

Comments

@pfigel

@kcristiano fyi since you are likely to hit this if you pull from master with #21167 merged

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[pfigel]

r-run confirms membership creation works now and the original issue is still fixed. LGTM, thanks for catching that!

[eileenmcnaughton]

thanks @pfigel @seamuslee001 - I guess those 'null's might catch us a few more times with using v4 api

[colemanw]

Right. APIv4 on the outside does the right thing and treats actual NULL as null and treats the string "null" as a string.
Internally it converts null to the string "null" for the benefit of our idiot database object.

[eileenmcnaughton]

lol