dev/core#2758 - Fix contribution activity campaign propagation

[pfigel]

Overview

This fixes an issue where contribution campaigns may not be propagated to the corresponding contribution activity when the request that triggers activity creation does not explicitly set the campaign_id parameter.

Before

Contribution activity campaign is not set sometimes.

After

Contribution activity campaign matches contribution campaign.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Thanks @pfigel - the test seems to make this an easy merge

[eileenmcnaughton]

Ohh - I just hit an error with this merged - doing more digging

[eileenmcnaughton]

#21171