APIv4 - Emit notices about deprecated join aliases

[colemanw]

Overview

Gives notices from APIv4 to alert developers to update their join syntax if needed.
Switches internal API calls and unit tests to use the non-deprecated syntax.

Old Syntax

civicrm_api4('Contact', 'get', [
  'select' => ['employer.display_name'],
]);

New Syntax

civicrm_api4('Contact', 'get', [
  'select' => ['employer_id.display_name'],
]);

Technical Details

Now using e.g. employer instead of employer_id will emit deprecation notice.
The aliases were deprecated a few months ago to reduce ambiguity, as not every FK field ends in "_id".
See #20130

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@colemanw

It hard failed in api_v3 tests

PHP Fatal error:  Allowed memory size of 2147483648 bytes exhausted (tried to allocate 20480 bytes) in /home/jenkins/bknix-dfl/build/core-20716-4ex7n/web/sites/all/modules/civicrm/CRM/Utils/API/HTMLInputCoder.php on line 136
PHP Stack trace:
PHP   1. {main}() /home/jenkins/bknix-dfl/extern/phpunit8/phpunit8.phar:0
PHP   2. PHPUnit\TextUI\Command::main() /home/jenkins/bknix-dfl/extern/phpunit8/phpunit8.phar:671
PHP   3. PHPUnit\TextUI\Command->run() phar:///home/jenkins/bknix-dfl/extern/phpunit8/phpunit8.phar/phpunit/TextUI/Command.php:101
PHP   4. PHPUnit\TextUI\TestRunner->doRun() phar:///home/jenkins/bknix-dfl/extern/phpunit8/phpunit8.phar/phpunit/TextUI/Command.php:129
PHP   5. PHPUnit\Framework\TestSuite->run() phar:///home/jenkins/bknix-dfl/extern/phpunit8/phpunit8.phar/phpunit/TextUI/TestRunner.php:462
PHP   6. PHPUnit\Framework\TestSuite->run() phar:///home/jenkins/bknix-dfl/extern/phpunit8/phpunit8.phar/phpunit/Framework/TestSuite.php:481
PHP   7. api_v3_OrderTest->run() phar:///home/jenkins/bknix-dfl/extern/phpunit8/phpunit8.phar/phpunit/Framework/TestSuite.php:481
PHP   8. PHPUnit\Framework\TestResult->run() phar:///home/jenkins/bknix-dfl/extern/phpunit8/phpunit8.phar/phpunit/Framework/TestCase.php:662
PHP   9. api_v3_OrderTest->runBare() phar:///home/jenkins/bknix-dfl/extern/phpunit8/phpunit8.phar/phpunit/Framework/TestResult.php:577
PHP  10. api_v3_OrderTest->runTest() phar:///home/jenkins/bknix-dfl/extern/phpunit8/phpunit8.phar/phpunit/Framework/TestCase.php:888
PHP  11. api_v3_OrderTest->runTest() /home/jenkins/bknix-dfl/build/core-20716-4ex7n/web/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:256
PHP  12. api_v3_OrderTest->testGetOrderParticipant() phar:///home/jenkins/bknix-dfl/extern/phpunit8/phpunit8.phar/phpunit/Framework/TestCase.php:1212
PHP  13. api_v3_OrderTest->createPartiallyPaidParticipantOrder() /home/jenkins/bknix-dfl/build/core-20716-4ex7n/web/sites/all/modules/civicrm/tests/phpunit/api/v3/OrderTest.php:95

but also looks like there are some failures in the api_v4_AllTests suite as well

[seamuslee001]

This seems fine to merging