APIv4 - Deprecate nonstandard syntax for implicit joins #20130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The APIv4 prototype used a string-manipulation hack to make implicit joins appear more friendly, e.g. it would transform `contact_id.*` to `contact.*`. However this made the generation of such joins less predictable, as not all FK fields end in `_id` (notably, custom ContactRef fields do not). This preserves the nonstandard syntax for backward-compat while favoring the new syntx in the API Explorer.
|
(Standard links)
|
|
retest this please |
|
Test coverage is stellar; this can be merged without manual review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The APIv4 prototype used a string-manipulation hack to make implicit joins appear more friendly, e.g. it would transform
contact_id.*tocontact.*.However this made the generation of such joins less predictable, as not all FK fields end in
_id(notably, custom ContactRef fields do not).This preserves the nonstandard syntax for backward-compat while favoring the new syntax in the API Explorer.
Comments
For now the deprecated syntax works normally, just isn't advertised in the Api Explorer. Someday we can emit deprecation warnings, and maybe in the future remove them altogether.