Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php8-compact] Allow for CiviCRM to be installed by 3rd parties using… #20625

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

seamuslee001
Copy link
Contributor

… composer on php8 systems

Overview

This would permit sites running Drupal 9 for example to install / update civicrm if their CLI or similar uses php8

Before

Cannot install or update civicrm via composer if php version is > 7.4

After

Can install or update civicrm via composer if php versions is > 7.4

I know that we have ~8 test failures still to go but most of those are actual issues not specifically related to php8 but php8 highlights them well. I'm not sure if that should be a blocker to doing this tho.

ping @eileenmcnaughton @totten @demeritcowboy @colemanw @MikeyMJCO

@civibot
Copy link

civibot bot commented Jun 16, 2021

(Standard links)

@civibot civibot bot added the master label Jun 16, 2021
@demeritcowboy
Copy link
Contributor

Another alternative is to just tell people they can use --ignore-platform-reqs if they really want to install civi with php 8 via composer.

By the way drupal 9.2 was released today and I can't seem to prevent composer from choosing it no matter what I tell it. Maybe it decides it's the "right" one for php 8 even if I specify 9.1.

@seamuslee001
Copy link
Contributor Author

@demeritcowboy sure we can do that but I think there is a point at which we need to say "Yes CiviCRM can be installed on php8" and I think once #20616 and #20623 are both resolved then I think we are kind of there, the last few test failures are actual legit issues and all php8 is doing is surfacing them more rather than actually being compatibility issues with php8 IMO

@demeritcowboy
Copy link
Contributor

Ok yes I see your point. Yes with php 8 you can physically composer download the files and e.g. run cv core:install.

@seamuslee001 seamuslee001 force-pushed the allow_civicrm_install_php8 branch from cc3a5c1 to d6e906e Compare June 19, 2021 21:24
@totten
Copy link
Member

totten commented Jun 19, 2021

I think that - since we're at the point where the tests pass on CiviCRM-Core-Edge - it makes sense to update composer.json and treat this as installable.

We could (as an additional/distinct thing) provide a warning during the installation or status-check to say that PHP 8 support is still early/incomplete (e.g. beta-period) and other bugs could crop up.

@totten totten added the merge ready PR will be merged after a few days if there are no objections label Jun 19, 2021
@totten
Copy link
Member

totten commented Jun 21, 2021

Several of the recent builds for master on CiviCRM-Core-Edge (PHP8) have been passing:

Screen Shot 2021-06-21 at 3 01 51 PM

The one recent failure is due to traditionally flaky tests.

@totten totten merged commit 1acdec4 into civicrm:master Jun 21, 2021
@seamuslee001 seamuslee001 deleted the allow_civicrm_install_php8 branch June 21, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants