Skip to content

Commit

Permalink
Merge pull request #20625 from seamuslee001/allow_civicrm_install_php8
Browse files Browse the repository at this point in the history
[php8-compact] Allow for CiviCRM to be installed by 3rd parties using…
  • Loading branch information
totten authored Jun 21, 2021
2 parents 40df867 + d6e906e commit 1acdec4
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
}
},
"require": {
"php": "~7.2",
"php": "~7.2 || ~8",
"cache/integration-tests": "~0.17.0",
"dompdf/dompdf" : "~1.0.0",
"firebase/php-jwt": ">=3 <6",
Expand Down
4 changes: 2 additions & 2 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/phpunit/CRM/Upgrade/FormTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public function testComposerRequirementMatch() {
$composerJsonRequirePhp = preg_replace(';[~^];', '', $composerJson['require']['php']);
$actualMajorMinor = preg_replace(';^[\^]*(\d+\.\d+)\..*$;', '\1', $composerJsonRequirePhp);
$expectMajorMinor = preg_replace(';^(\d+\.\d+)\..*$;', '\1', \CRM_Upgrade_Incremental_General::MIN_INSTALL_PHP_VER);
$this->assertEquals($expectMajorMinor, $actualMajorMinor, "The PHP version requirements in CRM_Upgrade_Form ($expectMajorMinor) and composer.json ($actualMajorMinor) should specify same major+minor versions.");
$this->assertStringContainsString($expectMajorMinor, $actualMajorMinor, "The PHP version requirements in CRM_Upgrade_Form ($expectMajorMinor) and composer.json ($actualMajorMinor) should specify same major+minor versions.");
}

}

0 comments on commit 1acdec4

Please sign in to comment.