Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2568 Enotice fix + test #20188

Merged
merged 1 commit into from
May 3, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Same as #20178 but with a test
(and a couple of changes to support that)

Overview

dev/core#2568 Enotice fix + test

Before

This is mostly about adding the tests for dev/core#2568 - it might be nicer to merge that one to actually fix the bug

After

Test added

Technical Details

@demeritcowboy so this adjusts another call to use getIDs() - once again I don't feel like I can replicate the issue we were hitting before

Comments

@civibot
Copy link

civibot bot commented Apr 29, 2021

(Standard links)

Same as civicrm#20178 but with a test
(and a couple of changes to support that)
@eileenmcnaughton
Copy link
Contributor Author

@demeritcowboy are you able to review this? I have a follow up - but it's just a test that builds off this test - which I'll put up when this is merged

@demeritcowboy
Copy link
Contributor

jenkins retest this please (since some relates to #20187)

@demeritcowboy
Copy link
Contributor

This seems ok. Tried a couple variations.
The setContributionIds() is only used for tests. The other replacements seem ok.

@demeritcowboy demeritcowboy merged commit 068c4e1 into civicrm:master May 3, 2021
@eileenmcnaughton eileenmcnaughton deleted the contto branch May 3, 2021 19:31
@eileenmcnaughton
Copy link
Contributor Author

thanks @demeritcowboy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants