dev/core#2568 Enotice fix + test #20188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #20178 but with a test
(and a couple of changes to support that)
Overview
dev/core#2568 Enotice fix + test
Before
This is mostly about adding the tests for dev/core#2568 - it might be nicer to merge that one to actually fix the bug
After
Test added
Technical Details
@demeritcowboy so this adjusts another call to use getIDs() - once again I don't feel like I can replicate the issue we were hitting before
Comments