Make send letter function available to searchkit, individual contributions #20187
Conversation
|
(Standard links)
|
|
This looks fine to me but will leave this to @demeritcowboy for formal review |
| <tr> | ||
| <td class="label-left">{$form.group_by.label} {help id="id-contribution-grouping"}</td> | ||
| <td>{$form.group_by.html}</td> | ||
| </tr> |
There was a problem hiding this comment.
If you don't have this on the template then you get a different type of notice in "single" mode: Notice: Undefined index: group_by in CRM_Contribute_Form_Task_PDFLetter->postProcess() (line 177 of .../CRM/Contribute/Form/Task/PDFLetter.php).
There was a problem hiding this comment.
@demeritcowboy I hit that enotice writing the test in another PR & added this line to the other PR that addresses https://github.com/civicrm/civicrm-core/pull/20188/files#diff-32b6d0d15de0f43a21f476f94999902d89e3498fc00ee55e4c817ec767a4d42fR179
There was a problem hiding this comment.
Ok.
The "other issue" referred to in the original description here I think was that an intermediate version of #20161 had more manipulating of contribution ids and it was giving buildContributionArray a null.
Overview
Make send letter function available to searchkit, individual contributions
Before
Send (thank you) letter function only available from search display results
After
Available from search kit & individual contribution rows
Technical Details
If there are no contribution tokens this enotice is hit #20178 (pre-existing)
@demeritcowboy I thought there was another issue with getSingle but this seemed to work fine so maybe it was ^^
Comments