dev/core#2164 Exporting in localized civicrm crashes due to long translations in columns T_Boolean #19957

bjendres · 2021-03-31T07:04:48Z

Overview

Patch for CORE-2146. Quote from there:

Export tmp tables are created with varchar(16) for T_BOOLEAN types. This may be sufficient for the short-worded language
English but if translated we get longer export values. So this should be 32 or more

Before

Export of all contact data with at least one contact with an email on hold in German l10n crashes with Data too long exception.

After

Export works again.

Technical Details

This is a re-implementation of @wannesderoy's #18920

Fix OSM Javascript to work on Search Kit display

This also moves template assignments to the email function

… contact record Also removes the possibility to set a user-defined password for WordPress users.

… you pages

Makes typing a bit stricter, uses preferred strpos function

…ne item

Part of using the mergeHandler to (slowly) make code more readable. changes from self::mergeLocations(); to mergeHandler->mergeLocations()

dev/core#2498 Fix regression on saving dedupe rules

civibot · 2021-03-31T07:04:50Z

(Standard links)

If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

5.36

[REF] Extract getMembershipTypeValues

monishdeb · 2021-03-31T12:07:17Z

Test failure seems related https://test.civicrm.org/job/CiviCRM-Core-PR/40108/

bjendres · 2021-03-31T12:47:50Z

Yes, thanks @monishdeb. It seems to be more complicated than I thought, and maybe we have to extend all the ID fields to 64 characters as well. I'll adjust the PR

[REF] Move function from static class to OO class

eileenmcnaughton · 2021-03-31T20:46:22Z

Not quite yet...

CRM_Export_BAO_ExportTest.testExportSpecifyFields with data set #0
CRM_Export_BAO_ExportTest.testGetSQLColumnsAndHeaders with data set #0
CRM_Export_BAO_ExportTest.testGetSQLColumnsAndHeaders with data set #1
CRM_Export_BAO_ExportTest.testGetSQLColumnsAndHeaders with data set #2
CRM_Export_BAO_ExportTest.testGetSQLColumnsAndHeaders with data set #3
CRM_Export_BAO_ExportTest.testGetSQLColumnsAndHeaders with data set #4
CRM_Export_BAO_ExportTest.testGetSQLColumnsAndHeaders with data set #5
CRM_Export_BAO_ExportTest.testGetSQLColumnsAndHeaders with data set #6

(Can you squash them at the end?)

Expose mapping search task to Search Kit

dev/financial#171 - Don't try to money_format html

Donot over-ride total amount incase contribution has more than one line item

dev/core#527 use public title for on behalf profile and confirm/thank you profile in emails

dev/financial#171 - Trigger an error if non-numeric value passed to Money::format()

[REF] [Towards membership api] more consistent handling on amount

[REF] Minor cleanup - strictness & formatting

eileenmcnaughton · 2021-04-01T21:40:55Z

@bjendres are you able to squash the commits now you have beaten jenkins into submission?

Fix for dev/core#2503

dev/wordpress#82 Add support for creating WordPress accounts from the contact record

bjendres · 2021-04-03T17:42:34Z

@bjendres are you able to squash the commits now you have beaten jenkins into submission?

looks like I'm not. idk what happened, but nothing good. I'll open a new PR :(

bjendres · 2021-04-03T17:50:24Z

(messed up and) withdrawn in favour of #19963

seamuslee001 and others added 14 commits March 23, 2021 20:17

Expose mapping search task to Search Kit

8fccc8a

Fix OSM Javascript to work on Search Kit display

[REF] [Towards membership api] more consistent handling on amount

53480c5

This also moves template assignments to the email function

dev/wordpress#82 Add support for creating WordPress accounts from the…

633d512

… contact record Also removes the possibility to set a user-defined password for WordPress users.

[REF] Extract getMembershipTypeValues

9e582c5

dev/core#527 use public title for on behalf profile and confirm/thank…

fc2e199

… you pages

trigger an error if non-numeric

7652b05

[REF] Minor cleanup

e908d4a

Makes typing a bit stricter, uses preferred strpos function

dev/core#2498 Fix regression on saving dedupe rules

a9ade36

Donot over-ride total amount incase contribution has more than one li…

c64b189

…ne item

Adding test to support fix

df43ca0

[REF] Move function from static class to OO class

a5e9dbe

Part of using the mergeHandler to (slowly) make code more readable. changes from self::mergeLocations(); to mergeHandler->mergeLocations()

Merge pull request civicrm#19952 from eileenmcnaughton/5.36

8fbbfea

dev/core#2498 Fix regression on saving dedupe rules

extending the @wannesderoy patch from civicrm#18920

31c5844

adjusting unit tests

df7cc14

civibot bot added the master label Mar 31, 2021

eileenmcnaughton and others added 2 commits March 31, 2021 22:33

Merge pull request civicrm#19956 from civicrm/5.36

8e88fa0

5.36

Merge pull request civicrm#19924 from eileenmcnaughton/mem_ex

f0cf4ce

[REF] Extract getMembershipTypeValues

bjendres and others added 5 commits March 31, 2021 15:01

integers are affected as well

db43311

adjusting unit tests

0f608ae

don't try to money_format html

f9044d4

Merge pull request civicrm#19955 from eileenmcnaughton/merge_locations

da4aa95

[REF] Move function from static class to OO class

dev/core#527 simpler solution

6b04b7e

eileenmcnaughton added 4 commits April 1, 2021 09:47

Merge pull request civicrm#19561 from seamuslee001/search_task_map

88ecb42

Expose mapping search task to Search Kit

Merge pull request civicrm#19958 from demeritcowboy/htmlmoney

c6d5e7a

dev/financial#171 - Don't try to money_format html

Merge pull request civicrm#19951 from pradpnayak/fixgetlineitem

d67ca01

Donot over-ride total amount incase contribution has more than one line item

Merge pull request civicrm#19937 from samuelsov/core#527

0278c62

dev/core#527 use public title for on behalf profile and confirm/thank you profile in emails

seamuslee001 and others added 5 commits April 1, 2021 09:21

Merge pull request civicrm#19938 from demeritcowboy/php74-money

9e81577

dev/financial#171 - Trigger an error if non-numeric value passed to Money::format()

Merge pull request civicrm#19911 from eileenmcnaughton/new

788b304

[REF] [Towards membership api] more consistent handling on amount

Merge pull request civicrm#19949 from eileenmcnaughton/dedupe

aaaabd3

[REF] Minor cleanup - strictness & formatting

adjusting unit tests

74cdcad

Fix for dev/core#2503

55bf40f

Merge pull request civicrm#19962 from jaapjansma/dev_2503

6517979

Fix for dev/core#2503

mlutfy changed the title ~~Issue/2164~~ dev/core#2164 Exporting in localized civicrm crashes due to long translations in columns T_Boolean Apr 2, 2021

mlutfy and others added 3 commits April 2, 2021 12:24

Merge pull request civicrm#18982 from mlutfy/wp82

78ed520

dev/wordpress#82 Add support for creating WordPress accounts from the contact record

extending the @wannesderoy patch from civicrm#18920

4ade2ea

Merge remote-tracking branch 'origin/issue/2164' into issue/2164

7138889

bjendres closed this Apr 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dev/core#2164 Exporting in localized civicrm crashes due to long translations in columns T_Boolean #19957

dev/core#2164 Exporting in localized civicrm crashes due to long translations in columns T_Boolean #19957

bjendres commented Mar 31, 2021

civibot bot commented Mar 31, 2021

monishdeb commented Mar 31, 2021

bjendres commented Mar 31, 2021

eileenmcnaughton commented Mar 31, 2021

eileenmcnaughton commented Apr 1, 2021

bjendres commented Apr 3, 2021

bjendres commented Apr 3, 2021

dev/core#2164 Exporting in localized civicrm crashes due to long translations in columns T_Boolean #19957

dev/core#2164 Exporting in localized civicrm crashes due to long translations in columns T_Boolean #19957

Conversation

bjendres commented Mar 31, 2021

Overview

Before

After

Technical Details

civibot bot commented Mar 31, 2021

monishdeb commented Mar 31, 2021

bjendres commented Mar 31, 2021

eileenmcnaughton commented Mar 31, 2021

eileenmcnaughton commented Apr 1, 2021

bjendres commented Apr 3, 2021

bjendres commented Apr 3, 2021