dev/core#527 use public title for on behalf profile and confirm/thank you profile in emails #19937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
OK - i think I can let this slip through without a test - nice to get it wrapped up & definitely a valuable improvement - thanks @samuelsov @demeritcowboy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Following on #19144 and #19291
Screens have been fixed in PR19291. The remaining PR is to fix profile title in receipt emails. It should use frontend title if available.
Before
With a frontend title defined in a profile used in a contribution page or an event page, the receipt displays the administrative title.
After
The receipt email shows the frontend title.