dev/release#16 - Cleanup empty upgrade steps

CRM/Upgrade/Incremental/php/FiveEighteen.php

@@ -58,7 +58,7 @@ public function setPostUpgradeMessage(&$postUpgradeMessage, $rev) {
    * @param string $rev
    */
   public function upgrade_5_18_alpha1($rev) {
-    $this->addTask(ts('Upgrade DB to %1: SQL', array(1 => $rev)), 'runSql', $rev);
+    // Not used // $this->addTask(ts('Upgrade DB to %1: SQL', array(1 => $rev)), 'runSql', $rev);
     $this->addTask('Update smart groups to reflect change of unique name for is_override', 'updateSmartGroups', [
       'renameField' => [
         ['old' => 'is_override', 'new' => 'member_is_override'],

CRM/Upgrade/Incremental/php/FiveEleven.php

@@ -58,7 +58,7 @@ public function setPostUpgradeMessage(&$postUpgradeMessage, $rev) {
    * @param string $rev
    */
   public function upgrade_5_11_alpha1($rev) {
-    $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev);
+    // Not used // $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev);
     $this->addTask('Update smart groups where jcalendar fields have been converted to datepicker', 'updateSmartGroups', [
       'datepickerConversion' => [
         'grant_application_received_date',
@@ -78,6 +78,7 @@ public function upgrade_5_11_alpha1($rev) {
    * @param string $rev
    */
   public function upgrade_5_11_beta1($rev) {
+    // Not used // $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev);
     if (Civi::settings()->get('civimail_multiple_bulk_emails')) {
       $this->addTask('Update any on hold groups to reflect field change', 'updateOnHold', $rev);
     }

CRM/Upgrade/Incremental/php/FiveFourteen.php

@@ -58,7 +58,7 @@ public function setPostUpgradeMessage(&$postUpgradeMessage, $rev) {
    * @param string $rev
    */
   public function upgrade_5_14_alpha1($rev) {
-    $this->addTask(ts('Upgrade DB to %1: SQL', array(1 => $rev)), 'runSql', $rev);
+    // Not used // $this->addTask(ts('Upgrade DB to %1: SQL', array(1 => $rev)), 'runSql', $rev);
     // Additional tasks here...
     // Note: do not use ts() in the addTask description because it adds unnecessary strings to transifex.
     // The above is an exception because 'Upgrade DB to %1: SQL' is generic & reusable.

CRM/Upgrade/Incremental/php/FiveNineteen.php

@@ -52,7 +52,7 @@ public function setPostUpgradeMessage(&$postUpgradeMessage, $rev) {
    * @param string $rev
    */
   public function upgrade_5_19_alpha1($rev) {
-    $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev);
+    // Not used // $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev);
     $this->addTask('Add api4 menu', 'api4Menu');
     $this->addTask('Add is_active field to civicrm_status_pref', 'addColumn', 'civicrm_status_pref', 'is_active',
       "tinyint(4) DEFAULT '1' COMMENT 'Is this status check active'", FALSE, '5.19.0');

CRM/Upgrade/Incremental/php/FiveSeventeen.php

@@ -96,6 +96,7 @@ public function upgrade_5_17_alpha1($rev) {
    * @param string $rev
    */
   public function upgrade_5_17_1($rev) {
+    // Not used // $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev);
     // Need to do this again because the alpha1 version had a typo and so didn't do anything.
     $this->addTask(ts('Add pptx to accepted attachment file types'), 'updateFileTypes');
   }

CRM/Upgrade/Incremental/php/FiveSix.php

@@ -58,7 +58,7 @@ public function setPostUpgradeMessage(&$postUpgradeMessage, $rev) {
    * @param string $rev
    */
   public function upgrade_5_6_beta2($rev) {
-    $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev);
+    // Not used // $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev);
     $this->addTask('dev/core#107 - Add Activity\'s default assignee options', 'addActivityDefaultAssigneeOptions');
   }
 

CRM/Upgrade/Incremental/php/FiveThirtyOne.php

@@ -73,7 +73,7 @@ public function upgrade_5_31_alpha1($rev) {
 
   public function upgrade_5_31_beta2($rev) {
     $this->addTask('Restore null-ity of "civicrm_group.title" field', 'groupTitleRestore');
-    $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev);
+    // Not used // $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev);
   }
 
   public static function enableEwaySingleExtension(CRM_Queue_TaskContext $ctx) {

CRM/Upgrade/Incremental/php/FiveThirtySix.php

@@ -67,7 +67,7 @@ public function setPostUpgradeMessage(&$postUpgradeMessage, $rev) {
    * @param string $rev
    */
   public function upgrade_5_36_alpha1(string $rev): void {
-    $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev);
+    // Not used // $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev);
 
     $this->addTask('core-issue#2422 - Add created_id to civicrm_saved_search', 'addColumn',
       'civicrm_saved_search', 'created_id', "int(10) unsigned DEFAULT NULL COMMENT 'FK to contact table.'");

CRM/Upgrade/Incremental/php/FiveThirtyThree.php

@@ -52,7 +52,7 @@ public function setPostUpgradeMessage(&$postUpgradeMessage, $rev) {
    * @param string $rev
    */
   public function upgrade_5_33_alpha1($rev) {
-    $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev);
+    // Not used // $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev);
     $this->addTask('Add column civicrm_dashboard.directive', 'addColumn', 'civicrm_dashboard', 'directive', "varchar(255) COMMENT 'Element name of angular directive to invoke (lowercase hyphenated format)'");
   }
 

CRM/Upgrade/Incremental/php/FiveTwentyFive.php

@@ -80,7 +80,7 @@ public function upgrade_5_25_alpha1($rev) {
   }
 
   public function upgrade_5_25_beta3($rev) {
-    $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev);
+    // Not used // $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev);
     $this->addTask('Convert CiviContribute settings', 'updateContributeSettings');
   }
 

CRM/Upgrade/Incremental/php/FiveTwentyNine.php

@@ -81,7 +81,7 @@ public function upgrade_5_29_alpha1($rev) {
    * @param string $rev
    */
   public function upgrade_5_29_beta1($rev) {
-    $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev);
+    // Not used // $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev);
     $this->addTask('Make label field non required on price field value', 'priceFieldValueLabelNonRequired');
   }