dev/release#16 - Cleanup empty upgrade steps

[totten]

Overview

Streamline the upgrader by removing a number of empty upgrade steps.

This patch is blocked on the dependency #19743 (which accounts for the first half-dozen commits). It furthers https://lab.civicrm.org/dev/release/-/issues/16.

ping @colemanw

Technical Details

Here was my process:

• cd into CRM/Upgrade/Incremental/sql
• Run ls -l on subset of files
• Make a list of files that were 55-63 bytes long. Display them and confirm that they contain no real instructions.
• Take the list of removed versions. Grep to see if those versions have PHP functions.
• If there is a PHP function, it may have a runSql() step that needs to be disabled.

In reviewing the diffs, you should generally see two kinds of changes:

• Several *.mysql.tpl files are removed -- all of these empty, notwithstanding boilerplate comments.
• In some of the upgrade_X_Y_Z() functions, calls to runSql() are commented out. That's because the identified files no longer exist. (One can verify they don't exist by skimming, eg, ls CRM/Upgrade/Incremental/sql/ | sort | grep ^5)

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@totten this needs rebasing now - but it also did not pass my tests - ie I used the sql from the 4.5 tarball and then ran the upgrade & it failed on a missing sql file

[eileenmcnaughton]

I'm pretty sure the issue I hit would also be covered by the unit tests TBH

[eileenmcnaughton]

Not blocked anymore - just needs fixing up

[totten]

@eileenmcnaughton Thanks for that ping.

I've rebased now. Additionally, for testing, I used this procedure*

• Load BUILDKIT/vendor/civicrm/upgrade-test/databases/4.7.31-setupsh.sql.bz2
• Run existing upgrader and take DB snapshot
• Load BUILDKIT/vendor/civicrm/upgrade-test/databases/4.7.31-setupsh.sql.bz2
• Run modified upgrader and take DB snapshot

Aside from the civicrm_cache and civicrm_log (timestamps), they appeared the same.

[eileenmcnaughton]

I don't think I need to re-do those same test steps - I did something similar on the other PR - if this passes let's merge it

[monishdeb]

Merging it as per MOP tag