Remove unreachable code & variable cleanup in membership back office form template

[eileenmcnaughton]

Overview

Removes some unreachable code and cleans up some variables

Before

• The 'else' part of the if (term) {} else {} is unreachable
  -References to membershipType are allMemberships[memType] which is confusing

After

else bit gone
Values assigned to array membershipType. membershipTypeID consistently used for the variable meaning membership type id - was memType AND membershipType - both retrieved from the same jquery

Technical Details

Term is always set at this point unless we are dealing with a priceset - in which case the early return would have been hit - ergo term is always set

We also know that this code is unreachable as in the 6 years it has been in the
codebase no-one has reported the bug in it. It uses total_amount not total_amount_numerci
in the first part of the calculation - this would fail when the decimal separator
is not a decimal

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Looks good.

[eileenmcnaughton]

Thanks - I'll wait until it's passed / merged & then close the others (in case there is some issue with the test run)