Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Remove unused variables #19646

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[REF] Remove unused variables

Before

existingAmount is never used except in this if so cannot be true. feeTotal
is used above this point but not below it - so this code is extraneous

After

poof

Technical Details

Comments

Touches same code as #19644 but this is particularly straight forward so likely to get a quick merge - I'll rebase that if so (or this if that is merged first)

existingAmount is never used except in this if so cannot be true. feeTotal
is used above this point but not below it - so this code is extraneous
@civibot
Copy link

civibot bot commented Feb 22, 2021

(Standard links)

@civibot civibot bot added the master label Feb 22, 2021
@colemanw
Copy link
Member

@eileenmcnaughton just put them both into the same PR & save yourself the trouble of rebasing. I'll merge.

@eileenmcnaughton
Copy link
Contributor Author

@colemanw great - I've figured out that it goes a bit further - so moving to #19647 - will close this & the other if you are comfortable with that + the other

@eileenmcnaughton eileenmcnaughton merged commit 323454a into civicrm:master Feb 22, 2021
@eileenmcnaughton eileenmcnaughton deleted the exist branch February 22, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants