[NFC] Improve cleanup on membershipStatus to cope with undeleted memberships #16756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
changed the title
totten
reviewed
Mar 20, 2020
| $result = $this->callAPISuccess('MembershipStatus', 'Delete', ['id' => $membershipStatusID]); | ||
| public function membershipStatusDelete(int $membershipStatusID) { | ||
| $this->callAPISuccess('Membership', 'get', ['status_id' => $membershipStatusID, 'api.Membership.get' => 1]); | ||
| $this->callAPISuccess('MembershipStatus', 'Delete', ['id' => $membershipStatusID]); |
There was a problem hiding this comment.
Most of this PR looks cleaner/NFC -- eg the second call (MembershipStatus.Delete) looks essentially the same (omitting the unusued result variable).
I have to admit, it feels like I'm missing something - why add the call to Membership.get (chained with another Membership.get) if there's no output and no obvious side-effect? Is there some hidden side-effect of Membership.get?
There was a problem hiding this comment.
Nope - that looks like a typo - fixed
eileenmcnaughton
force-pushed
the
memtest
branch
from
4353304 to
31c3ac9
Compare
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This makes the cleanup function more robust
Before
It will fail if not all memberships are deleted
After
Memberships handled
Technical Details
This might fail on the first pass as it forces the type to be int & gets rid of the silliness of calling it to do nothing
Comments