dev/core#1599/Deceased Contact's Membership Marked to Deceased via Inline

[kartik1000]

Signed-off-by: Kartik Kathuria [email protected]

Overview
The Deceased Contact's Membership will also be Deceased, if you mark a contact as deceased even via Inline. The BAO Contact Create function will call the updateMemberhship function and change the Contact's Membership Status. Added Test as well for the same.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[kartik1000]

@eileenmcnaughton I have fixed any checkstyle warnings, Please review.

[eileenmcnaughton]

Can we now remove these lines ...

civicrm-core/CRM/Contact/Form/Contact.php

Lines 910 to 918 in dfd10cd

	if (isset($params['contact_id'])) {
	// process membership status for deceased contact
	$deceasedParams = [
	'contact_id' => CRM_Utils_Array::value('contact_id', $params),
	'is_deceased' => CRM_Utils_Array::value('is_deceased', $params, FALSE),
	'deceased_date' => CRM_Utils_Array::value('deceased_date', $params, NULL),
	];
	$updateMembershipMsg = CRM_Member_BAO_Membership::updateMembershipStatus($deceasedParams, $this->_contactType);
	}

[eileenmcnaughton]

One of the 2 fails - api.v4.Entity.ConformanceTest.testConformance - is a known bug in our test suite :-(

The other one is being caused (I think) because your test is not deleting the membership it created. This might help - #16756

As an aside we will want you to squash your git commits down to a single commit - the general trick is

1. make sure you have a coffee first
2. git rebase -i origin/master
3. when you have your commits right git push -f

[eileenmcnaughton]

Actually the class you are using already created a membershipStatus in the setup so you can use that - from the setup

    $this->_contactID = $this->individualCreate();
    $this->_membershipTypeID = $this->membershipTypeCreate(['member_of_contact_id' => $this->_contactID]);
    $this->_membershipStatusID = $this->membershipStatusCreate('test status');

[kartik1000]

If I use, the membershipStatus in the setup, i think the teardown function will automatically delete that membership so then I won't have to call the delete function and it will pass the 2nd test as well. Am I right? or will I have to call the delete function even then?

[kartik1000]

Ok @eileenmcnaughton, Thanks! I will make the desired changes and let you know :)

[kartik1000]

Can we now remove these lines ...

civicrm-core/CRM/Contact/Form/Contact.php

Lines 910 to 918 in dfd10cd

	if (isset($params['contact_id'])) {
	// process membership status for deceased contact
	$deceasedParams = [
	'contact_id' => CRM_Utils_Array::value('contact_id', $params),
	'is_deceased' => CRM_Utils_Array::value('is_deceased', $params, FALSE),
	'deceased_date' => CRM_Utils_Array::value('deceased_date', $params, NULL),
	];
	$updateMembershipMsg = CRM_Member_BAO_Membership::updateMembershipStatus($deceasedParams, $this->_contactType);
	}

@eileenmcnaughton, I am not sure of removing this, because the normal edit still works through Form/Contact.php So, removing this might break that. I will also try and confirm it.

[kartik1000]

@eileenmcnaughton, all tests have passed and I have even squashed the commits. Please check.

[eileenmcnaughton]

Great - I tested this & it works - yay - for merging your commit to core!

[colemanw]

FYI @kartik1000 I've been trying to get rid of unnecessary uses of CRM_Utils_Array::value in favor of the ?? coalesce operator which is simpler.

I've done #16874 to clean it up (and some other code cleanup in that file while I was at it).

[kartik1000]

Great @colemanw! Yes if it makes it simpler. Why not.

[colemanw]

No problem. Thanks again for your contribution @kartik1000