Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#522 CRM-19767 dev/core#204 Add Case Tokens to emails #16105

Merged
merged 4 commits into from
Jan 8, 2020

Conversation

seamuslee001
Copy link
Contributor

Overview

This adds in the case tokens to emails as per PR #11291 also incorporates the unit tests for that PR from @varshith in ticket https://lab.civicrm.org/dev/core/issues/204

Before

No case tokens can be used in PDF letters or once off emails

After

This adds the ability to use case tokens on PDF Letters and single emails

ping @colemanw @jamienovick @eileenmcnaughton

@civibot
Copy link

civibot bot commented Dec 13, 2019

(Standard links)

@civibot civibot bot added the master label Dec 13, 2019
…d also switch the createEmailActivity to using API

Add in check of mail log as well
@mattwire
Copy link
Contributor

mattwire commented Jan 3, 2020

@seamuslee001 Is it possible to use the new token processor here? See eg. #14662

@eileenmcnaughton
Copy link
Contributor

@seamuslee001 I'm OK with this as a reviewers cut if you are familiar with what this does & confident in it. Agree it's good to do what @mattwire says but ok to leave out of scope given this adds the test

@seamuslee001
Copy link
Contributor Author

Merging based on @eileenmcnaughton 's comment and @mattwire i think there is going to be lot of refactor to these functions to make that happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants