Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#522 CRM-19767 - Add case tokens to email activities #11291

Closed
wants to merge 2 commits into from

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Nov 17, 2017

Overview

In CiviCRM core, case tokens had only been partially implemented. This extends them to work in email activities.

Before

  • When doing Print/Merge Document from a case, tokens for {case.id}, etc, were available.
  • When doing Send Email from a case, the tokens were missing.

After

When doing Send Email from a case, tokens for {case.id}, etc, are now available.

Comments

Originally submitted as #10252


@eileenmcnaughton
Copy link
Contributor

You totally know what I'm going to say this needs....

@eileenmcnaughton
Copy link
Contributor

@colemanw I think this needs tests & if that's not on your priority list I think we should close it & re-open if that changes

@colemanw
Copy link
Member Author

@jamienovick originally asked me to do this PR and @guanhuan was planning to assign it to someone at CompuCorp for adding a test.

@jamienovick
Copy link

@guanhuan over to you...

@guanhuan
Copy link
Contributor

@colemanw This totally fell through the cracks. Will get this assigned for next week.

cc @jamienovick

@guanhuan
Copy link
Contributor

@vinuvarshith has started a Gitlab ticket for this and have created some tests. He has a question regarding one of the test he is writing. @colemanw would you be able to advise? https://lab.civicrm.org/dev/core/issues/204

@eileenmcnaughton
Copy link
Contributor

@guanhuan seems to require an answer from your guy again

@eileenmcnaughton
Copy link
Contributor

@guanhuan @colemanw this is nearly a year old - we should close & track in gitlab until someone is enthused to complete it if no-one is in that state right now

@eileenmcnaughton eileenmcnaughton changed the title CRM-19767 - Add case tokens to email activities dev/core#522 CRM-19767 - Add case tokens to email activities Nov 14, 2018
@eileenmcnaughton
Copy link
Contributor

@guanhuan @colemanw per previous comments closing this to track through gitlab until someone wants to prioritise it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants