-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev/core#522 CRM-19767 - Add case tokens to email activities #11291
Conversation
You totally know what I'm going to say this needs.... |
@colemanw I think this needs tests & if that's not on your priority list I think we should close it & re-open if that changes |
@jamienovick originally asked me to do this PR and @guanhuan was planning to assign it to someone at CompuCorp for adding a test. |
@guanhuan over to you... |
@colemanw This totally fell through the cracks. Will get this assigned for next week. cc @jamienovick |
@vinuvarshith has started a Gitlab ticket for this and have created some tests. He has a question regarding one of the test he is writing. @colemanw would you be able to advise? https://lab.civicrm.org/dev/core/issues/204 |
@guanhuan seems to require an answer from your guy again |
Overview
In CiviCRM core, case tokens had only been partially implemented. This extends them to work in email activities.
Before
After
When doing Send Email from a case, tokens for {case.id}, etc, are now available.
Comments
Originally submitted as #10252