Remove CRM_Contact_Form_Search_Custom_Basic from searches added on install. #15979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stall. From civicrm#15963 this search appears to do what the main basic search does but we can see that to make it work with sort etc we have to make changes to the BAO_Query object - doing that to support a custom search scares me & we have a big picture position that we should move these from core to an extension. However, an easy first step is not to add on new installs. In the case of this search it seems like an easy call as it doesn't add anything discernable
|
(Standard links)
|
eileenmcnaughton
changed the title
|
@eileenmcnaughton you also need to run |
|
@seamuslee001 OK - done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Do not add the Custom Basic search on new civi installs any more
Before
Search is available. As the deprecation notice suggests sorting has never worked properly for this report & maintaining it seems silly given how little it seems to add & our general preference for moving core custom searches into an extension
After
Search no longer gets added on new installs
Technical Details
From #15963 this search appears to do what the main basic search does but
we can see that to make it work with sort etc we have to make changes to the BAO_Query object - doing
that to support a custom search scares me & we have a big picture position that we should move these
from core to an extension. However, an easy first step is not to add on new installs. In the case of
Comments
@seamuslee001