Fix e-notice about inability to fill up prevnext cache by setting tag and group table names

[seamuslee001]

… and group table names

Overview

This fixes an E-notice when you use the Basic Search Custom search and you filter on a group or a tag

Before

E-notice shows

After

e-notice disappears

Technical Details

It seemed like when it built the from clause and the where clause different group_contact and entity_tag table names were being generated. So this fixes it by making it a property of the class

ping @eileenmcnaughton

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@seamuslee001 I can't replicate the notice on 5.20 or master - this was the search I tried

[seamuslee001]

@eileenmcnaugton I was generating it when filtering using group and tags at the same time

[eileenmcnaughton]

Hmm I didn't get it - although my search got no results - can you add a screenshot to the template?

[seamuslee001]

ah @eileenmcnaughton i think i see the issue now you were doing a search from Contacts -> find contacts

This happens at hte search Contacts -> Custom Searches -> Basic Search

here is a screenshot

[seamuslee001]

and the search criteria

[eileenmcnaughton]

@seamuslee001 so looking at this has made me question what we are doing - and in particular to think that we should not treat deprecation notices as regressions unless they are popping up all the time. Where they occur in obscure places we have always used deprecation notices to flush these out & I don't think they have to be fixed as a regression.

In this case I think the right answer is to deprecate & discourage use of this report - there is already a good alternative - basic-search. Fixing it requires code changes that affect basic search & advanced search etc & all for something that ideally we would not be maintaining.

I propose we

1. stop adding it on new installs Remove CRM_Contact_Form_Search_Custom_Basic from searches added on install. #15979
2. leave the deprecation notice there as it accurately says the search doesn't work well.
3. consider adding yet another deprecation notice at the whole search level
4. maybe get more active about moving some of these searches to extensions - probably one search per extension rather than all in one - then we can decide which to keep supporting

[seamuslee001]

@eileenmcnaughton i would be fine with that for this report, i still feel like e-notices are better fixed sooner rather than later so to speak. In regards to this e-notice there is only 1 other search and its the Event Aggregate one that triggers it but i dunno. i'm ok with 1 and 2 at the moment we can ponder 3 & 4

[seamuslee001]

closing in favour of #15979