dev/core#1241 : Custom field value for a new Event based on an Event Template are not checked causing false validation message and Event not to save

[monishdeb]

Overview

Steps to reproduce:

1. Create a custom field, assign to Events and set to be a required field
2. Create a new Event
3. Select an Event Template for the Event
4. Set a value for the custom field
5. Save the Event
6. Validation message appears for custom field, even though a value has been set
7. Event does not save
8. If no Event Template is selected then field validation is correct and the Event will save

Before

After

ping @mlutfy @jusfreeman

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[jusfreeman]

Adding links to make it easier for others to grok:
Related lab bug report and context, https://lab.civicrm.org/dev/core/issues/1241
PR which appears to have introduced the regression #14480

[jusfreeman]

Will test and report back.

[eileenmcnaughton]

Note we need to merge to 5.18 first & then 5.17

[eileenmcnaughton]

5.18 version #15296

[jusfreeman]

Happy to confirm that Event custom field validation is correct after applying this patch.

[jusfreeman]

Thanks again @monishdeb

[eileenmcnaughton]

test fail unrelated - merging this & giving 5.18 MOP