dev/core#553: Creating new event takes value from default value not from saved template for custom fields

[monishdeb]

Overview

When creating a new event using a template the new event screen is taking the default values directly from the custom fields, and not from what's saved in the event template.

Steps to replicate:

1. Create a custom field for Events
2. Set default value say 'abc' for that custom field
3. Create/Edit an event template and save with custom field value say 'def'
4. Now create a new event using that event template

Issue - Custom field is set to default value 'abc' instead of 'def'

Before

After

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[scoobird]

Tested this, and it works as expected. Thanks!

[colemanw]

I've checked the code. Merging based on review and passing tests.

[jusfreeman]

This change possibly introduced a regression bug, see https://lab.civicrm.org/dev/core/issues/1241#note_23222