Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php 7.2 warning message fix on install. #13325

Closed
wants to merge 1 commit into from
Closed

Php 7.2 warning message fix on install. #13325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions install/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,15 +424,18 @@
* $description[2] - The test error to show, if it goes wrong
*/
class InstallRequirements {
var $errors, $warnings, $tests, $conn;
protected $errors = [];
protected $warnings = [];
var $tests, $conn;

// @see CRM_Upgrade_Form::MINIMUM_THREAD_STACK
const MINIMUM_THREAD_STACK = 192;

/**
* Just check that the database configuration is okay.
* @param $databaseConfig
* @param $dbName
*
* @param array $databaseConfig
* @param string $dbName
*/
public function checkdatabase($databaseConfig, $dbName) {
if ($this->requireFunction('mysqli_connect',
Expand Down Expand Up @@ -485,7 +488,7 @@ public function checkdatabase($databaseConfig, $dbName) {
);
if (!CRM_Core_DAO::requireSafeDBName($databaseConfig['database'])) {
$this->error($testDetails);
return FALSE;
return;
}
else {
$this->testing($testDetails);
Expand Down