Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php 7.2 warning message fix on install. #13325

Closed
wants to merge 1 commit into from

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fixes a warning message when installing on php 7.2

Before

error

After

fixed

Technical Details

This declares errors and warnings as class properties to avoid
errors on counting them.

Also remove an unused return false as this is not consistent with the rest of the
function

Comments

This declares errors and warnings as class properties to avoid
errors on counting them.

Also remove an unused return false as this is not consistent with the rest of the
function
@civibot
Copy link

civibot bot commented Dec 19, 2018

(Standard links)

@civibot civibot bot added the master label Dec 19, 2018
@totten
Copy link
Member

totten commented Dec 20, 2018

Hrm, oops. Looks like this is concurrent with #13326 and addresses the same use-case. I saw that one first and merged because it seemed very simple.

This patch is actually better (it cleans up some older-style/less-clear code), and the patches are not mutually exclusive. But this one is slightly longer - so we might want to r-run it first.

@eileenmcnaughton eileenmcnaughton deleted the 72_index branch April 26, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants