CRM-21744 fix proximity search to work with smart groups #11645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmcnaughton
force-pushed
the
prox_smart_group
branch
from
fe84d2d to
8820aa0
Compare
eileenmcnaughton
force-pushed
the
prox_smart_group
branch
from
8820aa0 to
c2c09cb
Compare
|
Tested - results are limited to the smart group, as intended. Looks ok. |
|
@aydun is this OK for merge on pass? Note it's pretty obscure functionality so I think a bit of UI testing should suffice |
|
FYI - I note that search results can be selected (checkboxes on left), but the '0 records selected' does not change and the actions drop-down is not available. But that is the same on previous versions so not caused by this PR and not related to smart groups. |
|
Yes, ok to merge on pass |
|
Merging based on @aydun review - per above - this is a pretty obscure corner of Civi & we will be testing this specifically on the rc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix proximity search to work with smart groups
Before
When using the proximity search it allows a smart group to be selected, but if you DO select one then it returns 0 results
After
The proximity search appropriately filters by smart groups
Technical Details
On analysing the search I decided that the the functionality was created in the search & then later exposed in Advanced search / the main query object, leaving the proximity search as just a subset of the advanced search. I decided rather than recreate the smart group logic I would simply point it the main Query object & remove the wrangling from the Proximity search
Comments
This is the last of my geocoding ones I think :-) Further work in an extension. I will rebase once #11643 & #11543 are merged