CRM-21742 Proximity search validation improvement #11643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmcnaughton
changed the title
eileenmcnaughton
changed the title
|
@eileenmcnaughton please rebase it as #11540 is merged |
eileenmcnaughton
force-pushed
the
prox_search
branch
from
9269cdc to
bef4d7e
Compare
|
@monishdeb done - I was so totally happy to do that! |
eileenmcnaughton
changed the title
|
test this please |
|
Great change :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Change hard error to form validation message for invalid/ ungeocodable data entered in the proximity search.
Before
After
Technical Details
The PR introduces a rule for the custom searches which they can override to perform validation.
Comments
I will rebase this once #11540 is merged