Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21424 Set receipt date when downloading pdf receipt #11289

Merged
merged 3 commits into from
Nov 18, 2017
Merged

CRM-21424 Set receipt date when downloading pdf receipt #11289

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2439fa7
CRM-21424 Set receipt date when downloading pdf receipt
kainuk Nov 16, 2017
82b862f
remove obsolete comment
kainuk Nov 17, 2017
1db3dde
Added test
kainuk Nov 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CRM/Contribute/BAO/Contribution.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4722,7 +4722,7 @@ public static function sendMail(&$input, &$ids, $contributionID, &$values,
$values['contribution_status'] = CRM_Core_PseudoConstant::getLabel('CRM_Contribute_BAO_Contribution', 'contribution_status_id', $contribution->contribution_status_id);
$return = $contribution->composeMessageArray($input, $ids, $values, $returnMessageText);
// Contribution ID should really always be set. But ?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment doesn't make sense to me. Maybe it's no longer relevant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is obsolete - on line 4714 the existence of the contribution is tested, and this test fails when the id is not set.

if (!$returnMessageText && (!isset($input['receipt_update']) || $input['receipt_update']) && empty($contribution->receipt_date)) {
if ((!isset($input['receipt_update']) || $input['receipt_update']) && empty($contribution->receipt_date)) {
civicrm_api3('Contribution', 'create', array('receipt_date' => 'now', 'id' => $contribution->id));
}
return $return;
Expand Down