CRM-21424 Set receipt date when downloading pdf receipt #11289
Conversation
|
test this please |
eileenmcnaughton
added
the
merge ready
|
This makes sense to me - if there is an input option we should respect it & the parameter does not seem like it would be set other than deliberately |
CRM/Contribute/BAO/Contribution.php
Outdated
| @@ -4722,7 +4722,7 @@ public static function sendMail(&$input, &$ids, $contributionID, &$values, | |||
| $values['contribution_status'] = CRM_Core_PseudoConstant::getLabel('CRM_Contribute_BAO_Contribution', 'contribution_status_id', $contribution->contribution_status_id); | |||
| $return = $contribution->composeMessageArray($input, $ids, $values, $returnMessageText); | |||
| // Contribution ID should really always be set. But ? | |||
There was a problem hiding this comment.
This comment doesn't make sense to me. Maybe it's no longer relevant?
There was a problem hiding this comment.
Comment is obsolete - on line 4714 the existence of the contribution is tested, and this test fails when the id is not set.
|
The issue is worthy.
Thanks for this good work. |
colemanw
removed
the
merge ready
|
@JoeMurray In the download screen the user has the option to prevent the update of the receipt field (stand behaviour is an update, the user can disable it). I think that is correct because only the user knows of the first downloaded pdf really was sent out). |
|
jenkins, test this please |
|
Looks like issues have been addressed & the change looks good |
CRM-21424 Set receipt date when downloading pdf receipt
Overview
Set receipt date when downloading pdf receipt.
Before
Does not set de receipt date when downloading a receipt pdf.
After
Does set the receipt date when downloading the receipt pdf.
Technical Details
https://issues.civicrm.org/jira/browse/CRM-21424 contains an example to reproduce
Comments
issue was introduced with the fix for CRM-18166.