-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build universal binary instead of architecture dependent #995
Conversation
ae55057
to
744b5db
Compare
Unfortunately, got an error in SwiftFormat, same as nicklockwood/SwiftFormat#1645
|
a51ea6a
to
9723fdd
Compare
9723fdd
to
afdf283
Compare
I think we can just drop SwiftFormat from Tart's dependencies and install it from HomeBrew in /cc @fkorotkov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amalchuk left couple comments. Thank you for working on this!
@edigaryev agreed on the SwiftFormat installation.
If build hooks will not be changed, we can stay using @fkorotkov Please, do review of changes and test, how archives are processing by the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I guess we'll know how it all goes on the next release shortly 😅
Added feature for building a universal binary (both arm64 and x86_64).