-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pulling/pushing VMs to OCI-compatible registries #32
Conversation
Another note. I think we should deprioritize tests in favor of a sooner release and follow up with more tests in a separate PR. Also will be great to add some logging to the push/pull process since it can take quite a while and will be great to update users about progress. |
Seems there is an issue with the reference parsing as well: tart push monterey-vanilla ghcr.io/cirruslabs/macos-monterey-vanilla:12.3.1
error: unexpected input
--> input:1:45
1 | …-monterey-vanilla:12.3.1
| ^ expected end of input |
f21d4ce
to
80645ff
Compare
Seems OK, made a couple of improvements (e.g. 0144913). Also re-checked against https://docs.docker.com/registry/spec/auth/token/, the only thing that's missing is that we don't specify a |
Deprioritized to #34.
Implemented in 27bb3c5. |
...which also uses powers of 10.
Sources/tart/VMDirectory+OCI.swift
Outdated
@@ -67,6 +67,10 @@ extension VMDirectory { | |||
} | |||
|
|||
func pushToRegistry(registry: Registry, reference: String) async throws { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove this method completely and remove the for loop where it's called.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove this method completely and remove the for loop where it's called.
Oh, good catch.
Fixed in 821a99b.
ca94d6f
to
b6fd0ed
Compare
This still needs some things to be done before this gets merged:
check→ done in Support pulling/pushing VMs to OCI-compatible registries #32 (comment)Registry
implementation against OCI distribution specificationgarbage collection when deleting cached OCI VMs (w.r.t. symbolic links)→ moved to Implement garbage collection when deleting cached OCI VMs (w.r.t. symbolic links) #37better→ moved to Improve RemoteName parser #35RemoteName
parsermore tests→ Registry functional/integration tests #34Registry
functional/integration tests→ added in 80645ffWWWAuthenticate
unit testsResolves #6.