Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RemoteName parser #35

Closed
edigaryev opened this issue May 3, 2022 · 1 comment · Fixed by #225 or #269
Closed

Improve RemoteName parser #35

edigaryev opened this issue May 3, 2022 · 1 comment · Fixed by #225 or #269
Assignees
Labels
GA Issue to state General Availability aka 1.0.0

Comments

@edigaryev
Copy link
Collaborator

edigaryev commented May 3, 2022

OCI image names are widely used, but a formal spec on their format is missing. Here's what what OCI's Unique Resource Identifiers says on the subject, for example:

How do we ask for containers? We ask for a unique resource identifier (uri) which broadly comes in this form:

There's nothing formal in the entire document, except that the resource identifier is split into registry, organization and repository.

There's an implementation in Docker's distribution package, which is way more complicated than our's RemoteName parser.

There's an attempt to derive an EBNF grammar which is quite readable at first glance (compared to a bunch of regular expression above), so perhaps we should validate it and stick to it.

@fkorotkov fkorotkov added the GA Issue to state General Availability aka 1.0.0 label May 3, 2022
@edigaryev edigaryev self-assigned this Aug 4, 2022
@edigaryev edigaryev reopened this Sep 20, 2022
@edigaryev
Copy link
Collaborator Author

edigaryev commented Sep 24, 2022

Here's an upstream PR that once merged, will allow us to bring back the new parser: antlr/antlr4#3906.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GA Issue to state General Availability aka 1.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants