This repository has been archived by the owner on May 8, 2024. It is now read-only.
Fall back to checking out HEAD #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested locally by building a |
edigaryev
reviewed
Sep 24, 2022
internal/executor/executor.go
Outdated
| logUploader.Write([]byte("\nFailed to fetch merge ref! PR might not be mergable. Falling back to head ref...")) | ||
| headRefSpec := fmt.Sprintf("+refs/pull/%s/head:refs/remotes/origin/pull/%[1]s", pr_number) | ||
| fetchOptions.RefSpecs = []config.RefSpec{config.RefSpec(headRefSpec)} | ||
| err = repo.Fetch(fetchOptions) |
There was a problem hiding this comment.
Shouldn't we use FetchContext() here too?
There was a problem hiding this comment.
I copied the logic from below retry logic. 🤔 Will check if we need to change it in both places.
edigaryev
approved these changes
Sep 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case merge ref is not available. These edge cases were cauhgt by integration tests in Cirrus CI:
Related to #247 and #249