This repository has been archived by the owner on May 8, 2024. It is now read-only.
Use merge reference instead of head #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GH's `checkout` action [seems to use this reference for clones](https://github.com/actions/checkout/blob/eb8a193c1dbf4bbb2053320cef52bacc1a485839/__test__/ref-helper.test.ts#L50-L58). See https://stackoverflow.com/questions/63594658/git-refs-merge-vs-head-in-pull-request
|
I've manually checked that for https://github.com/flutter/flutter this works and git fetch origin pull/112191/head:test
fatal: couldn't find remote ref pull/112191/head
❯ git fetch origin pull/112191/merge:test
remote: Enumerating objects: 32, done.
remote: Counting objects: 100% (32/32), done.
remote: Compressing objects: 100% (27/27), done.
remote: Total 32 (delta 13), reused 13 (delta 5), pack-reused 0
Unpacking objects: 100% (32/32), 43.51 KiB | 1.89 MiB/s, done.
From github.com:flutter/flutter
* [new ref] refs/pull/112191/merge -> test |
|
I also tested it on this PR https://github.com/cirruslabs/http-cache-action/actions/runs/3107625033/jobs/5035941706#step:3:101 |
edigaryev
approved these changes
Sep 22, 2022
|
On the other hand it confuses users of GitHub actions sometimes actions/checkout#504 but I guess it's better then the situation like right now when the cloning is not working. I guess if the |
fkorotkov
added a commit
that referenced
this pull request
Sep 23, 2022
Since the recent change in #247
fkorotkov
added a commit
that referenced
this pull request
Sep 23, 2022
Since the recent change in #247
fkorotkov
added a commit
that referenced
this pull request
Sep 25, 2022
fkorotkov
added a commit
that referenced
this pull request
Oct 20, 2022
And only if it fails like during the recent GH incident, try to fetch merge ref. We've see bunch of weird but rare transient fetch failures since #247 got deployed. Fixes cirruslabs/cirrus-ci-docs#1086
Merged
fkorotkov
added a commit
that referenced
this pull request
Oct 20, 2022
And only if it fails like during the recent GH incident, try to fetch merge ref. We've see bunch of weird but rare transient fetch failures since #247 got deployed. Fixes cirruslabs/cirrus-ci-docs#1086
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH's
checkoutaction seems to use this reference for clones.See https://stackoverflow.com/questions/63594658/git-refs-merge-vs-head-in-pull-request