Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs #13

Merged
merged 8 commits into from
Dec 25, 2024
Merged

Updated docs #13

merged 8 commits into from
Dec 25, 2024

Conversation

coderdan
Copy link
Contributor

No description provided.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Yuji Yokoo <[email protected]>
@yujiyokoo yujiyokoo mentioned this pull request Dec 13, 2024
```

### EQL value classes
[!NOTE]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prints as literal string. Maybe it's some other Markdown's syntax not supported by GitHub?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this isn't using the GitHub Markdown syntax correctly.

It should be:

Suggested change
[!NOTE]
> [!NOTE]
> The column type in the database is `cs_encrypted_v1` which is encrypted type defined in [EQL](https://github.com/cipherstash/encrypt-query-language/blob/main/docs/reference/PAYLOAD.md). Internally EQL uses JSON.

@yujiyokoo yujiyokoo marked this pull request as ready for review December 25, 2024 03:12
Copy link
Collaborator

@yujiyokoo yujiyokoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was just left there even though the work was done. I made it 'ready for review'. My PR onto this branch was approved and merged. I'm approving (the rest of) this branch now.

@yujiyokoo yujiyokoo merged commit 816e3ca into main Dec 25, 2024
1 check passed
@yujiyokoo yujiyokoo deleted the updated-docs branch December 25, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants