Start writing supported queries #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderdan
reviewed
Dec 15, 2024
coderdan
reviewed
Dec 15, 2024
coderdan
reviewed
Dec 15, 2024
yujiyokoo
force-pushed
the
update-supported-queries
branch
from
bfacca6 to
3e8d5c4
Compare
yujiyokoo
commented
Dec 16, 2024
coderdan
reviewed
Dec 17, 2024
reference/SUPPORTED_QUERIES.md
Outdated
|
|
||
| | EncryptedValue subclass | Supported lookups | Supported index type | | ||
| |-------------------------|----------------------------------|----------------------| | ||
| | EncryptedText | eq (EncryptedUniqueEquals) | "unique" | |
There was a problem hiding this comment.
Suggest putting anything that is a class name or "symbol" in backticks. EncryptedText instead of EncryptedText.
There was a problem hiding this comment.
EncryptedText also supports ORE but its only useful for ORDER BY. Maybe we could add that later because I think we don't yet support ordering in eqlpy, right?
There was a problem hiding this comment.
ORDER BY is supported ilke this: Customer.objects.order_by(CsOre648V1(F("name")).desc()).values().all() so we coulld add it but that may require further explanation. I don't know if we can make it simpler than that without doing a lot of work
coderdan
reviewed
Dec 17, 2024
coderdan
reviewed
Dec 17, 2024
coderdan
reviewed
Dec 17, 2024
coderdan
requested changes
Dec 17, 2024
* use backticks for identifiers * update example to use 'customers' * add links to EQL value types
coderdan
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at filling in the supported queries section