Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/kernels: Replace --ci with --repo #189

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

joestringer
Copy link
Member

Based on #184

Allow the user to provide the repo and provide examples for the CI
repository, rather than hardcoding lvh org OCI repos and CI flag.

Allow the user to provide the repo and provide examples for the CI
repository, rather than hardcoding lvh org OCI repos and CI flag.

Signed-off-by: Joe Stringer <[email protected]>
@joestringer
Copy link
Member Author

We could of course also/alternatively keep both flags if --ci is really commonly useful.

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I like it, even have it in the help docs is equally as easy as --ci I imagine.

@joestringer joestringer marked this pull request as ready for review April 16, 2024 15:38
@joestringer
Copy link
Member Author

@mtardy do you have a preference to merge this into your branch first, or merge your branch first and then this will rebase against the main branch, then merge there?

@mtardy
Copy link
Member

mtardy commented Apr 16, 2024

@mtardy do you have a preference to merge this into your branch first, or merge your branch first and then this will rebase against the main branch, then merge there?

I really don't have a preference

@joestringer joestringer merged commit 7cec9c2 into pr/mtardy/add-get-kernel Apr 16, 2024
1 check passed
@joestringer joestringer deleted the pr/joe/get-kernel-repo branch April 16, 2024 18:13
@joestringer
Copy link
Member Author

@mtardy I merged it in. You would need to pull that commit into your local tree if you wish to update PR #184.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants