-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a command to list kernel tags and pull kernels built by little-vm-helper-images #184
Conversation
This is to prepare the addition of two new commands: get and catalog that won't use the flag and thus we can no longer set the flag as persistent on the kernels function. Signed-off-by: Mahe Tardy <[email protected]>
Signed-off-by: Mahe Tardy <[email protected]>
e09bf8d
to
8fd3986
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm excited to see this! I didn't look too closely at the code yet, but I did wonder about one thing about the usability with being able to just copy+paste a container image URL to specify a kernel to pull, see the thread below.
This command allows to list the built kernels by LVHI. Signed-off-by: Mahe Tardy <[email protected]>
This one uses the google/go-containerregistry (or crane) library that can perform actions without a docker daemon running. Signed-off-by: Mahe Tardy <[email protected]>
Signed-off-by: Mahe Tardy <[email protected]>
8fd3986
to
8a969ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of minor nits where I would have made different decisions but if you feel strongly about them then that feedback doesn't need to be applied.
Allow the user to provide the repo and provide examples for the CI repository, rather than hardcoding lvh org OCI repos and CI flag. Signed-off-by: Joe Stringer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I could also replace the
lvh images pull
implementation so that it doesn't require a docker daemon (can also remove the dependency).