Remove codeql #1511
Merged
Remove codeql #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running codeql is a bit of an overkill at this point since we moved all the code to cilium/cilium repo except for main.go [^1]. [^1]: https://github.com/cilium/hubble/blob/main/main.go Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
requested review from
brlbil and
chancez
and removed request for
a team
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
michi-covalent
added a commit
that referenced
this pull request
Jun 4, 2024
Similar to #1511, I don't think it's necessary to run golangci-lint at this point. Signed-off-by: Michi Mutsuzaki <[email protected]>
Merged
brlbil
approved these changes
Jun 4, 2024
rolinh
pushed a commit
that referenced
this pull request
Jun 4, 2024
Similar to #1511, I don't think it's necessary to run golangci-lint at this point. Signed-off-by: Michi Mutsuzaki <[email protected]>
rolinh
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running codeql is a bit of an overkill at this point since we moved all the code to cilium/cilium repo except for main.go 1.
Footnotes
https://github.com/cilium/hubble/blob/main/main.go ↩