Skip to content

Commit

Permalink
Remove golangci-lint
Browse files Browse the repository at this point in the history
Similar to #1511, I don't think it's necessary to run golangci-lint at
this point.

Signed-off-by: Michi Mutsuzaki <[email protected]>
  • Loading branch information
michi-covalent authored and rolinh committed Jun 4, 2024
1 parent 40dc08a commit 0d37c40
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 127 deletions.
11 changes: 0 additions & 11 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,6 @@ jobs:
- uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1
with:
go-version-file: 'go.mod'
- name: Run static checks
uses: golangci/golangci-lint-action@a4f60bb28d35aeee14e6880718e0c85ff1882e64 # v6.0.1
with:
# renovate: datasource=docker depName=golangci/golangci-lint
version: v1.59.0
args: --config=.golangci.yml --verbose
skip-cache: true
- name: Run slowg analyzer
run: | # TODO: remove once slowg is integrated in golangci-lint
go install github.com/cilium/linters@latest
linters -slowg ./...
- name: Check module vendoring
run: |
go mod tidy
Expand Down
103 changes: 0 additions & 103 deletions .golangci.yml

This file was deleted.

13 changes: 0 additions & 13 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ RENOVATE_GITHUB_COM_TOKEN ?= $(shell gh auth token)

TEST_TIMEOUT ?= 5s

# renovate: datasource=docker depName=golangci/golangci-lint
GOLANGCILINT_WANT_VERSION = v1.59.0
GOLANGCILINT_IMAGE_SHA = sha256:8ad7dc3d98d77dec753f07408c7683ab854752a3eb8dc6a5e5f0728f9a89ae2c
GOLANGCILINT_VERSION = $(shell golangci-lint version 2>/dev/null)

# renovate: datasource=docker depName=library/golang
GOLANG_IMAGE_VERSION = 1.22.3-alpine3.19
GOLANG_IMAGE_SHA = sha256:f1fe698725f6ed14eb944dc587591f134632ed47fc0732ec27c7642adbe90618
Expand Down Expand Up @@ -90,14 +85,6 @@ bench: TEST_TIMEOUT=30s
bench:
$(GO_TEST) -bench=. $$($(GO) list ./...)

ifneq (,$(findstring $(GOLANGCILINT_WANT_VERSION:v%=%),$(GOLANGCILINT_VERSION)))
check:
golangci-lint run
else
check:
$(CONTAINER_ENGINE) run --rm -v `pwd`:/app -w /app docker.io/golangci/golangci-lint:$(GOLANGCILINT_WANT_VERSION)@$(GOLANGCILINT_IMAGE_SHA) golangci-lint run
endif

image:
$(CONTAINER_ENGINE) build $(DOCKER_FLAGS) -t $(IMAGE_REPOSITORY)$(if $(IMAGE_TAG),:$(IMAGE_TAG)) .

Expand Down

0 comments on commit 0d37c40

Please sign in to comment.