Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tamilmani1989 to azure group #184

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tamilmani1989
Copy link
Contributor

I have been working on integration of cilium in AKS/Azure and would like to volunteer for any work related to this area

@tamilmani1989 tamilmani1989 changed the title Adding tamilmani1989 to azure group add tamilmani1989 to azure group Dec 10, 2024
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamilmani1989 Thank you for your offer to volunteer as a reviewer for our group. We appreciate your enthusiasm and willingness to contribute.

While we are actively looking for new reviewers, we would look more specifically individuals who have already contributed and have some experience in the area. For example, contributions that could help demonstrate your motivation and build experience might include updating the current golang Azure dependencies which are deprecated. This task would require re-gaining familiarity with the Azure integration in Cilium and would make a meaningful impact on the project. The upstream GH issue is cilium/cilium#36869 if you would like to give it a go.

Thank you

@joestringer
Copy link
Member

I see that both @tamilmani1989 and @wedaly have requested to join the reviewer groups for this area, and I think you're probably both in a similar situation. Needless to say, having software engineers working for Azure being involved in the azure codowner group sounds like a great fit :) .

Similar to my feedback on some of the other recent proposals, the primary question to me is just whether the existing codeowners for the area feel confident that we can continue to provide consistent reviews in the area with the extended membership. This expectation is outlined in the contributor ladder for reviewers regarding track record. I don't doubt your ability to make useful contributions in this area, so demonstrating this with PRs or reviews in the area should hopefully be a fairly straightforward operation. If you can share links to those contributions then I think that can also speak to the question that @aanm is raising.

@wedaly
Copy link
Member

wedaly commented Jan 16, 2025

pointing to a few of the contributions @tamilmani1989 has made in this area:

Azure SIG doesn't have a huge amount of activity, but I think it would be very beneficial to the project to have TM as a reviewer. It's not an understatement to say that he's the world expert in Azure CNI.

@joestringer joestringer requested a review from aanm January 16, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants