request to add wedaly to sig-k8s #180
Conversation
Signed-off-by: Will Daly <[email protected]>
|
@cilium/sig-k8s |
|
Thanks for your willingness to contribute and help maintain Cilium @wedaly, we'd love to see you join the group assuming the reviewer expectations are met :) I see that we're looking for @cilium/sig-k8s codeowners / committers feedback on this proposal. As a matter of process, it could help this proposal if you could link to example contributions or reviews to help the codeowners to see your contributions particularly in this area. Even a general link to PRs/issues authored by you (example), or individual PRs where you were heavily involved in review. If members of @cilium/sig-k8s are not yet comfortable in adding you to the group that approves / gets assigned reviews, then perhaps @cilium/sig-k8s could provide pointers as to what they'd expect to see. Even before you become part of the group, we would welcome you to continue to contribute by sending PRs to improve the area and review PRs requesting feedback from @cilium/sig-k8s. Every contribution you make will help to build your reputation with other contributors and give confidence that the quality bar we uphold in this area as a community will continue to be upheld with your assistance. |
|
Thinking through the above a bit more from a process perspective, I wonder if it would help to have a template. Someone also mentioned that a search link like this can help to demonstrate prior participation in reviews: https://github.com/cilium/cilium/pulls?q=is%3Apr+reviewed-by%3Awedaly+ . The corresponding search link for submitted PRs is https://github.com/cilium/cilium/pulls?q=is%3Apr+author%3Awedaly+ . @xmulligan what do you think about adding a template for requests like this, would that make sense? |
|
Yea, I think it would make sense to have a template for that |
Thanks for the encouragement and suggestions @joestringer . I'll plan to dedicate time to reviewing the PRs in this queue. |
PR template for people requesting to become org members and reviewers to clarify what information is helpful when opening the PR As discussed in #180 (comment) Signed-off-by: Bill Mulligan <[email protected]>
|
I've suggested a template in #190. Happy to have any reviews. |
Request to add myself to sig-k8s. I'd like to help with code reviews, and this is the area I know best from my work integrating Cilium into AKS.