Introducing stylecheck linter to detect duplicate package imports in Go code
#30215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
nickolaev
requested review from
ldelossa,
youngnick,
tommyp1ckles,
nathanjsweet,
kaworu,
YutaroHayakawa,
pippolo84 and
brlbil
nickolaev
force-pushed
the
pr/nickolaev/staticcheck_linter
branch
from
af328d0 to
566936c
Compare
dylandreimerink
approved these changes
Jan 12, 2024
YutaroHayakawa
approved these changes
Jan 12, 2024
brlbil
requested changes
Jan 12, 2024
nickolaev
force-pushed
the
pr/nickolaev/staticcheck_linter
branch
from
566936c to
fca0de1
Compare
brlbil
approved these changes
Jan 12, 2024
rolinh
approved these changes
Jan 12, 2024
kaworu
reviewed
Jan 15, 2024
kaworu
added
area/CI
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
nickolaev
force-pushed
the
pr/nickolaev/staticcheck_linter
branch
from
fca0de1 to
1f43afd
Compare
nickolaev
changed the title
staticcheck linter to detect duplicate package imports in Go code.stylecheck linter to detect duplicate package imports in Go code
nickolaev
force-pushed
the
pr/nickolaev/staticcheck_linter
branch
from
1f43afd to
e784222
Compare
mhofstetter
approved these changes
Jan 15, 2024
tommyp1ckles
approved these changes
Jan 16, 2024
nickolaev
force-pushed
the
pr/nickolaev/staticcheck_linter
branch
from
e784222 to
8c8651f
Compare
|
/test |
nickolaev
force-pushed
the
pr/nickolaev/staticcheck_linter
branch
from
8c8651f to
b8a2974
Compare
nickolaev
force-pushed
the
pr/nickolaev/staticcheck_linter
branch
from
b8a2974 to
ac2c269
Compare
This will be invoked as part of the CI workflow linting. Signed-off-by: Nikolay Nikolaev <[email protected]>
After adding stylecheck in the previous commit, we do fix all the issues it found. The used command was: make golangci-lint Signed-off-by: Archisman Mridha <[email protected]> Signed-off-by: Nikolay Nikolaev <[email protected]> # Conflicts: # pkg/k8s/watchers/watcher.go # pkg/service/service.go
nickolaev
force-pushed
the
pr/nickolaev/staticcheck_linter
branch
from
ac2c269 to
6d40d3a
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce
stylechecklinter in.golangci.yaml, but enable it only for duplicate imports (ST1019)Then this PR fixes all the duplicate go imports found by running:
This is a re-spin of the original (abandoned) #28062 by @Archisman-Mridha
Fixes: #27676