Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate imports and enable stylecheck linter to prevent them #2364

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Mar 5, 2024

See commits for details.

Same as cilium/cilium#30215 did in cilium/cilium.

tklauser added 2 commits March 5, 2024 15:03
Found using the stylecheck linter ST1019 check.

Signed-off-by: Tobias Klauser <[email protected]>
Enable the stylecheck linter, but only check S1019 which will flag
duplicate imports.

Signed-off-by: Tobias Klauser <[email protected]>
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful

Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for IPsec.

@tklauser tklauser merged commit f39957b into main Mar 5, 2024
13 checks passed
@tklauser tklauser deleted the pr/tklauser/duplicate-imports branch March 5, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants