Get rid of KPR=probe and socket-LB protocols #22083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
brb
force-pushed
the
pr/brb/rm-kpr-probe-and-host-reach-svc
branch
4 times, most recently
from
75b79c6 to
39729ef
Compare
brb
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
brb
added
kind/cleanup
brb
changed the title
brb
changed the title
|
/test |
tklauser
approved these changes
Nov 14, 2022
gandro
approved these changes
Nov 14, 2022
brb
added a commit
to cilium/cilium-cli
that referenced
this pull request
Nov 14, 2022
It is going to removed in the Cilium v1.13. See cilium/cilium#22083. Signed-off-by: Martynas Pumputis <[email protected]>
borkmann
reviewed
Nov 14, 2022
borkmann
approved these changes
Nov 14, 2022
pchaigno
approved these changes
Nov 14, 2022
|
The This is coming from https://github.com/cilium/cilium-cli/blob/master/clustermesh/clustermesh.go#L1485 😞 |
tklauser
pushed a commit
to cilium/cilium-cli
that referenced
this pull request
Nov 14, 2022
It is going to removed in the Cilium v1.13. See cilium/cilium#22083. Signed-off-by: Martynas Pumputis <[email protected]>
The option was deprecated in v1.12, and it can be removed in v1.13. The KPR=probe was never ending source of confusion for users and us, so kthnxbye. Signed-off-by: Martynas Pumputis <[email protected]>
Deprecated in v1.12, scheduled to be removed in v1.13. Signed-off-by: Martynas Pumputis <[email protected]>
Signed-off-by: Martynas Pumputis <[email protected]>
Signed-off-by: Martynas Pumputis <[email protected]>
Signed-off-by: Martynas Pumputis <[email protected]>
To include the fix cilium/cilium-cli#1216. Signed-off-by: Martynas Pumputis <[email protected]>
Signed-off-by: Martynas Pumputis <[email protected]>
It's been replaced by the SocketLB field. Signed-off-by: Martynas Pumputis <[email protected]>
brb
force-pushed
the
pr/brb/rm-kpr-probe-and-host-reach-svc
branch
from
39729ef to
9f735eb
Compare
|
/test |
|
The Jenkins CI hit the IPSec flakes, while |
nathanjsweet
approved these changes
Nov 15, 2022
ldelossa
approved these changes
Nov 16, 2022
pchaigno
reviewed
Nov 16, 2022
|
The previously failing |
brb
force-pushed
the
pr/brb/rm-kpr-probe-and-host-reach-svc
branch
from
195548d to
9f735eb
Compare
brb
added
the
ready-to-merge
michi-covalent
pushed a commit
to michi-covalent/cilium
that referenced
this pull request
May 30, 2023
It is going to removed in the Cilium v1.13. See cilium#22083. Signed-off-by: Martynas Pumputis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both were deprecated in v1.12, and were scheduled for removal in v1.13.
Fix #22076
Fix #22077