Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clustermesh: Rename host-reachable-svc opt #1216

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

brb
Copy link
Member

@brb brb commented Nov 14, 2022

Rename to --bpf-lb-sock, as --enable-host-reachable-services was removed in cilium/cilium#22083.

Rename to --bpf-lb-sock, as --enable-host-reachable-services was
removed.

Signed-off-by: Martynas Pumputis <[email protected]>
@brb brb requested a review from a team as a code owner November 14, 2022 14:15
@brb brb requested a review from jrajahalme November 14, 2022 14:15
@brb brb temporarily deployed to ci November 14, 2022 14:15 Inactive
@brb brb added the kind/enhancement This would improve or streamline existing functionality. label Nov 14, 2022
@tklauser tklauser merged commit ea3ffed into master Nov 14, 2022
@tklauser tklauser deleted the pr/brb/clustermesh-socket-lb branch November 14, 2022 17:11
brb added a commit to cilium/cilium that referenced this pull request Nov 15, 2022
To include the fix cilium/cilium-cli#1216.

Signed-off-by: Martynas Pumputis <[email protected]>
@jrajahalme
Copy link
Member

@brb This broke external workload installs on Cilium 1.11, as --bpf-lb-sock is unknown there. It seems this change needs to be made conditional on the Cilium version?

@jrajahalme
Copy link
Member

Opened issue #1232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement This would improve or streamline existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants