-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows: refactor EKS workflows #442
Conversation
341422a
to
68db60d
Compare
|
Since this is an urgent PR for fixing regressions in |
68db60d
to
132fd05
Compare
Following merge of #400, we broke #391. This PR fixes the issue by refactoring both EKS workflows to be consistent with other workflows, now that we are creating a cluster with nodes available right away just like on other platforms, and thus do not need to split the `install`/`test` steps anymore. Fixes 3d2fbdb Signed-off-by: Nicolas Busseneau <[email protected]>
132fd05
to
a27c290
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@aanm has more context than me on the changes that are mentioned in the PR description here, and also implications on github workflows so I've pulled him in on review. |
ok let's ship it |
Following merge of #400, we broke #391.
This PR fixes the issue by refactoring both EKS workflows to be consistent with other workflows, now that we are creating a cluster with nodes available right away just like on other platforms, and thus do not need to split the
install
/test
steps anymore.