.github/workflows: wait for install job before checking aws-node DaemonSet #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
force-pushed
the
pr/tklauser/aws-node-wait
branch
from
f004c46 to
d1d73ab
Compare
tklauser
force-pushed
the
pr/tklauser/aws-node-wait
branch
from
d1d73ab to
66d649f
Compare
tklauser
changed the title
tklauser
force-pushed
the
pr/tklauser/aws-node-wait
branch
from
66d649f to
fc0fd7c
Compare
tklauser
force-pushed
the
pr/tklauser/aws-node-wait
branch
from
fc0fd7c to
73c2be9
Compare
…onSet Wait until the cilium-cli-install job completed and Cilium is installed before checking the status of the aws-node DaemonSet. Otherwise, we might fail the check if the aws-node DaemonSet is still terminating. Signed-off-by: Tobias Klauser <[email protected]>
|
Both EKS workflows passed:
Removing test commit and marking as ready to review. |
tklauser
force-pushed
the
pr/tklauser/aws-node-wait
branch
from
73c2be9 to
a7b3e89
Compare
nbusseneau
requested changes
Jul 19, 2021
| @@ -6,5 +6,4 @@ set -e | |||
| # Install Cilium | |||
| cilium install \ | |||
| --cluster-name "${CLUSTER_NAME}" \ | |||
| --wait=false \ | |||
There was a problem hiding this comment.
We already actively wait immediately after enabling Hubble in the next script. Initially, the whole point of splitting the EKS scripts into 2 separate install/test steps was to take advantage of the fact we install into clusters without any nodes, with nodes being added later.
Now that we don't have that and instead create clusters with nodes available right away, I think the split is not warranted anymore and we should switch back to a single script that works like the others.
There was a problem hiding this comment.
(following offline discussion: proposal in #442)
|
Let's close this in favor of #442. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait until the cilium-cli-install job completed and Cilium is installed
before checking the status of the aws-node DaemonSet. Otherwise, we
might fail the check if the aws-node DaemonSet is still terminating.