Prepare for v0.16.21 release #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added a commit
to cilium/cilium
that referenced
this pull request
Nov 28, 2024
Since commit 5417a3f ("cli/connectivity: Check for unexpected warning logs") we check for unexpected warnings in logs as part of the connectivity checks. This leads to some fallout in cilium/cilium-cli when pulling in that change[^1] for the upcoming cilium-cli v0.16.21 release, mainly due to the fact that Hubble and Hubble UI are enabled in the cilium/cilium-cli workflows. To work around that and don't block the next release of cilium-cli for too long, allow to specify log levels to check, so we can skip checking of warnings logs temporarily. In the long term all these warning logs should be addressed by either fixing their root cause, demoting their level or adding them to the ignore list. [^1]: cilium/cilium-cli#2869 Signed-off-by: Tobias Klauser <[email protected]>
tklauser
added a commit
to cilium/cilium
that referenced
this pull request
Nov 28, 2024
Since commit 5417a3f ("cli/connectivity: Check for unexpected warning logs") we check for unexpected warnings in logs as part of the connectivity checks. This leads to some fallout in cilium/cilium-cli when pulling in that change[^1] for the upcoming cilium-cli v0.16.21 release, mainly due to the fact that Hubble and Hubble UI are enabled in the cilium/cilium-cli workflows. To work around that and don't block the next release of cilium-cli for too long, allow to specify log levels to check by means of a hidden flag. This allows to skip checking of warnings logs temporarily. In the long term all these warning logs should be addressed by either fixing their root cause, demoting their level or adding them to the ignore list. [^1]: cilium/cilium-cli#2869 Signed-off-by: Tobias Klauser <[email protected]>
|
Most (all?) of the test failures are due to warning logs in the Cilium and Hubble UI logs. These get treated as errors since cilium/cilium#35723. To allow skipping this check temporarily (and not block the release for too long to wait for all fixes to be done and merged), I've added a flag to specify log levels to check: cilium/cilium#36231 |
tklauser
added a commit
to cilium/cilium
that referenced
this pull request
Nov 28, 2024
Since commit 5417a3f ("cli/connectivity: Check for unexpected warning logs") we check for unexpected warnings in logs as part of the connectivity checks. This leads to some fallout in cilium/cilium-cli when pulling in that change[^1] for the upcoming cilium-cli v0.16.21 release, mainly due to the fact that Hubble and Hubble UI are enabled in the cilium/cilium-cli workflows. To work around that and don't block the next release of cilium-cli for too long, allow to specify log levels to check by means of a hidden flag (by default, errors and warnings are both still checked). This allows to skip checking of warnings logs temporarily. In the long term all these warning logs should be addressed by either fixing their root cause, demoting their level or adding them to the ignore list. [^1]: cilium/cilium-cli#2869 Signed-off-by: Tobias Klauser <[email protected]>
tklauser
added a commit
to cilium/cilium
that referenced
this pull request
Nov 28, 2024
Since commit 5417a3f ("cli/connectivity: Check for unexpected warning logs") we check for unexpected warnings in logs as part of the connectivity checks. This leads to some fallout in cilium/cilium-cli when pulling in that change[^1] for the upcoming cilium-cli v0.16.21 release, mainly due to the fact that Hubble and Hubble UI are enabled in the cilium/cilium-cli workflows. To work around that and don't block the next release of cilium-cli for too long, allow to specify log levels to check by means of a hidden flag (by default, errors and warnings are both still checked). This allows to skip checking of warnings logs temporarily. In the long term all these warning logs should be addressed by either fixing their root cause, demoting their level or adding them to the ignore list. [^1]: cilium/cilium-cli#2869 Signed-off-by: Tobias Klauser <[email protected]>
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this pull request
Nov 28, 2024
Since commit 5417a3f ("cli/connectivity: Check for unexpected warning logs") we check for unexpected warnings in logs as part of the connectivity checks. This leads to some fallout in cilium/cilium-cli when pulling in that change[^1] for the upcoming cilium-cli v0.16.21 release, mainly due to the fact that Hubble and Hubble UI are enabled in the cilium/cilium-cli workflows. To work around that and don't block the next release of cilium-cli for too long, allow to specify log levels to check by means of a hidden flag (by default, errors and warnings are both still checked). This allows to skip checking of warnings logs temporarily. In the long term all these warning logs should be addressed by either fixing their root cause, demoting their level or adding them to the ignore list. [^1]: cilium/cilium-cli#2869 Signed-off-by: Tobias Klauser <[email protected]>
tklauser
force-pushed
the
pr/prepare-v0.16.21
branch
from
da074b8 to
967f8bc
Compare
tklauser
force-pushed
the
pr/prepare-v0.16.21
branch
from
967f8bc to
5923b33
Compare
tklauser
force-pushed
the
pr/prepare-v0.16.21
branch
from
5923b33 to
f6c0ae0
Compare
tklauser
force-pushed
the
pr/prepare-v0.16.21
branch
from
f6c0ae0 to
fe3f28b
Compare
tklauser
force-pushed
the
pr/prepare-v0.16.21
branch
from
fe3f28b to
a19de92
Compare
tklauser
force-pushed
the
pr/prepare-v0.16.21
branch
from
434e42b to
cfae452
Compare
|
Please consider this issue before doing a new release. |
|
thanks for the heads up @Foxboron i think i'm the one for suggested curling stable.txt from cilium/cilium repo, and i acknowledge that it's not great for downstream package managers to have releases that are not reproducible. @tklauser what do you think about getting the latest release from the vendored cilium/chart repo? that way the default stable cilium version won't move around. something like: edit: opened #2874 🐚 |
tklauser
force-pushed
the
pr/prepare-v0.16.21
branch
from
cfae452 to
5693756
Compare
|
Updated to cilium 1.17.0-pre.3 and running CI one more time. |
tklauser
force-pushed
the
pr/prepare-v0.16.21
branch
from
5693756 to
a12ad5a
Compare
brlbil
approved these changes
Dec 3, 2024
bimmlerd
approved these changes
Dec 5, 2024
|
Currently blocked on cilium/cilium#36358 getting merged to cilium/cilium. Once it is, I'll update this PR. |
1 task
The v0.14 branch is no longer maintainerd and with Cilium 1.13 EOLed this is no longer referenced in the docs. Remove it. Signed-off-by: Tobias Klauser <[email protected]>
The global IPsec key system is deprecated[^1], prefer the new per-tunnel key system. This switches most workflows over to the new system, except conformance-eks which needs[^2] addressed first. [^1]: cilium/cilium#33504 [^2]: cilium/cilium#32040 Signed-off-by: Tobias Klauser <[email protected]>
Signed-off-by: Tobias Klauser <[email protected]>
tklauser
force-pushed
the
pr/prepare-v0.16.21
branch
from
a12ad5a to
bfa8088
Compare
tklauser
removed
the
dont-merge/blocked
maintainer-s-little-helper
bot
added
the
ready-to-merge
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing CI but wait for Cilium v1.17.0-pre.3 to be released before reviewing/merging this.