curl'ing stable.txt from cilium/cilium makes builds unreproducible.
#2870
Assignees
Labels
kind/bug
Something isn't working
Comments
|
And to be clear, this is relevant for downstream packagers as there is no clear indication what the |
michi-covalent
added a commit
that referenced
this issue
Dec 3, 2024
Get the default Cilium version from vendored cilium/charts repo so that the build is reproducible. Fixes: #2870 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added a commit
to cilium/cilium
that referenced
this issue
Dec 3, 2024
Derive the default Cilium version from the source using vendored cilium/charts instead of injecting it at compile time. This helps ensure that the default version is consistent across all the downstream cilium-cli packages. Fixes: cilium/cilium-cli#2870 Signed-off-by: Michi Mutsuzaki <[email protected]>
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this issue
Dec 4, 2024
Derive the default Cilium version from the source using vendored cilium/charts instead of injecting it at compile time. This helps ensure that the default version is consistent across all the downstream cilium-cli packages. Fixes: cilium/cilium-cli#2870 Signed-off-by: Michi Mutsuzaki <[email protected]>
|
@michi-covalent Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
Currently the build is requiring to curl a
stable.txtfile fromcilium/ciliumupon building. It's unclear to me why this is needed, but as we are fetching from a continuously moving source the implication is that past releases ofcilium-cliis going to be unreproducible as the build inputs will be moving.This value should be hard coded pr release, and not fetched from
main.General Information
N/A
How to reproduce the issue
stable.txtcurl and see the checksum be different.The text was updated successfully, but these errors were encountered: