helm mode: Add EKS test coverage #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
force-pushed
the
pr/michi/eks
branch
from
7f90a78 to
c0698a7
Compare
michi-covalent
force-pushed
the
pr/michi/eks
branch
from
c0698a7 to
f16a4d3
Compare
michi-covalent
force-pushed
the
pr/michi/eks
branch
from
f16a4d3 to
ecdfce2
Compare
michi-covalent
force-pushed
the
pr/michi/eks
branch
from
ecdfce2 to
1547b90
Compare
|
✅ success: https://github.com/cilium/cilium-cli/actions/runs/4997969753 removing the temporary commit and marking it ready for review |
michi-covalent
force-pushed
the
pr/michi/eks
branch
from
1547b90 to
2932538
Compare
Ref: #1625 Signed-off-by: Michi Mutsuzaki <[email protected]>
- Move the logic to unschedule aws-node pods from Install to preinstall so that it can be shared between classic and helm mode. - Look for cni.chainingMode Helm value instead of generating configmap and looking for cni-chaining-mode field. It is alarming to see cilium-cli mutating objects that it does not own, but I guess that's a separate discussion altogether... Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/eks
branch
from
2932538 to
493031b
Compare
asauber
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1625